search

surge-synthesizer / stochas

The Stochas Sequencer
https://stochas.org
GNU General Public License v3.0
404 stars 35 forks source link

Create new 32-bit and 64-bit windows installers #109

Closed mthierman closed 1 year ago

baconpaul commented 2 years ago

Great!

Will azure run these or are they purely additive and we need to set up pipelines?

mthierman commented 2 years ago

I think if we replace line 165 where we run ISCC:

iscc //Obuild\\product //Fstochas_windows_installer //DSTOCHAS_VERSION=${STOCHAS_VERSION}.${GH} "install\\win\\install.iss"

with something like this:

iscc //Obuild\\product //Fstochas_windows_installer64 //DMyAppVersion=${STOCHAS_VERSION}.${GH} //DSTOCHAS_SRC="..\..\" //DSTOCHAS_BIN="..\..\build" "install\\win\\stochas64.iss"
iscc //Obuild\\product //Fstochas_windows_installer32 //DMyAppVersion=${STOCHAS_VERSION}.${GH} //DSTOCHAS_SRC="..\..\" //DSTOCHAS_BIN="..\..\build32" "install\\win\\stochas32.iss"

This should build 32 and 64 bit installers instead. And should publish with the existing windows task since that publishes the whole build/product folder already, if I'm understanding that task properly.

mthierman commented 2 years ago

I should also check what happens when I run this over an old install in case we need a cleanup task or something

Edit: So the old installer already leaves a mess if you install standalone after VST3 (it forces two installation processes).

The new installers use different locations and create a different entry in add/remove programs. I am not sure if we should add an InstallDelete section

mthierman commented 1 year ago

I've revisited this and don't think we should delete files from an existing install, so I think we either merge this or keep the original 32bit/64 bit install and possibly update that instead. Thoughts?

baconpaul commented 1 year ago

Any reason to not clean up the prior install? It’s not user data right just installed assets?

i should do the signed mac installer stuff here too like we do for the other properties. I’ll peek at that this week

oh and I should fix that zoom thing and turn in clap builds!

mthierman commented 1 year ago

If we delete the files it still leaves an entry in add/remove programs (since it's different GUID)

baconpaul commented 1 year ago

Can you whack the registry in the new install script? (Shudder)

mthierman commented 1 year ago

I added a PowerShell script to plumb the registry and run any previous uninstaller, should work on 32bit and 64bit Windows.