search

surge-synthesizer / surge-rack

Take Surge and factor it into modules for VCV Rack
GNU General Public License v3.0
168 stars 13 forks source link

Selecting PatchPlayer from module browser crashes Rack #216

Closed SteveRussell33 closed 5 years ago

SteveRussell33 commented 5 years ago

From log.txt [14.296 info src/SurgeModuleCommon.hpp:87] [SurgeRack] Instance: Module=PatchPlayer BuildInfo=os:win pluggit:7b7a0b4 surgegit:2ed1513 buildtime=Jun 14 2019 15:25:57 [14.343 info src/SurgeModuleCommon.cpp:98] [SurgeRack] SurgeStorage::dataPath = ./plugins-v1/SurgeRack/surge-data/ [14.343 info src/SurgeModuleCommon.cpp:99] SurgeStorage::userDataPath = [14.343 info src/SurgeModuleCommon.cpp:100] SurgeStorage::wt_list.size() = 307 [14.343 warn src/UserInteractionsRack.cpp:14] Surge Error Surge is not properly installed. Cannot find 'configuration.xml' in path ''. Please reinstall surge.

[14.343 warn src/UserInteractionsRack.cpp:14] Surge Error Surge Installation Error Surge was unable to load wavetables from ''. The directory contains no wavetables. Please reinstall using the Surge installer.

[14.359 warn src/UserInteractionsRack.cpp:14] Surge Error Surge Installation Error Surge was unable to load factory patches from ''. Surge found 0 factory patches. Please reinstall using the Surge installer.

Rack v1.dev.6b6c852 SurgeRack-1.beta1.7b7a0b4

As this is a Release beta build zip that I'm using the surge-data dir is under plugins-v1/SurgeRack (we discussed this before in the other issue - the neater option I think) so I can't see why this is failing as the data is all there.

Path error in src/SurgeModuleCommon.cpp?

baconpaul commented 5 years ago

Does plugins-v1/SurgeRack/surge-data/configuration.xml exist? What is the contents of plugins-v1/SurgeRack/?

baconpaul commented 5 years ago

Oh damnit no I know exactly what the problem is. Hold on. Patch coming.

baconpaul commented 5 years ago

(SurgePatchPlayer uses a different startup path for storage and will require special treatment)

baconpaul commented 5 years ago

Ahh and the reason it works for me is because I have the VST installed, which installs in a default location, so I am reading assets from the VST install by accident.

Thank you. This is a very valuable bug report. I have a fix coming together now.

baconpaul commented 5 years ago

Alright I was able to replicate this by uninstalling my system wide surge VST assets and running it; immediate crash. And I was able to fix it by threading the appropriate path through the different constructor path that is needed for this module. I saw the crash resolved so I pushed it

f7a75e8

a release with that commit will work. The release on the releases/ page now contains it. So if you could re-download and try again and if it works, close this issue, I would greatly appreciate it.

And thank you. That is two super useful bugs you have found which my system masked. Appreciate your patience and accuracy in reporting them.

SteveRussell33 commented 5 years ago

No problem Paul glad to help!

I have the VST as well (in a VST2 folder well away from VCV), didn't occur to me that might be a problem your end.

Confirming f7a75e853fae669bd0a4bcbaf4f23bc76096eb91 is good!

baconpaul commented 5 years ago

Fantastic! Thank you.

Most problems with surge-rack are a problem on my end :) 30 seconds after I read the log I knew exactly the problem and slapped my forehead. Appreciate it.

Also enjoy the module! If you combine it with the PolyGenerator from the latest BaconMusic you can get some very nice results...

SteveRussell33 commented 5 years ago

You're very welcome.

Thanks for the module tip! Will try that out.

baconpaul commented 5 years ago

Yup. The more natural approach is midi to it with v/oct to note, vel to vel and gate to gate. That lets you play surge in rack immediately basically.