search

surge-synthesizer / surge-rack

Take Surge and factor it into modules for VCV Rack
GNU General Public License v3.0
169 stars 13 forks source link

Twist crash #977

Open ContemporaryInsanity opened 10 months ago

ContemporaryInsanity commented 10 months ago

[819.380 info src/app/Browser.cpp:89 chooseModel] Creating module Surge XT Twist VCO [819.380 info /home/vortico/src/vcv/library/repos/SurgeXTRack/src/XTModule.h:73 showBuildInfo] [SurgeXTRack] Instance: Module=VCO BuildInfo=os:linux pluggit:SURGE_RACK_PLUG_VERSION surgegit:SURGE_RACK_SURGE_VERSION buildtime=Jan 3 2024 20:59:13 [819.385 info src/app/Browser.cpp:93 chooseModel] Creating module widget Surge XT Twist VCO [819.392 fatal adapters/standalone.cpp:49 fatalSignalHandler] Fatal signal 11. Stack trace: 20: ./Rack() [0x4043ed] 19: /lib/x86_64-linux-gnu/libc.so.6(+0x3c460) 18: /home/ewen/.Rack2/plugins-lin-x64/SurgeXTRack/plugin.so(+0x92f9b9) 17: /home/ewen/.Rack2/plugins-lin-x64/SurgeXTRack/plugin.so(+0x6c371c) 16: /home/ewen/.Rack2/plugins-lin-x64/SurgeXTRack/plugin.so(+0x3aa1fd) 15: /home/ewen/.Rack2/plugins-lin-x64/SurgeXTRack/plugin.so(+0x3ab0e1) 14: ./libRack.so(rack::widget::Widget::step()+0x36) 13: ./libRack.so(rack::widget::Widget::step()+0x36) 12: ./libRack.so(rack::widget::Widget::step()+0x36) 11: ./libRack.so(rack::widget::Widget::step()+0x36) 10: ./libRack.so(rack::widget::Widget::step()+0x36) 9: ./libRack.so(rack::widget::Widget::step()+0x36) 8: ./libRack.so(rack::ui::ScrollWidget::step()+0x13) 7: ./libRack.so(rack::app::RackScrollWidget::step()+0x36f) 6: ./libRack.so(rack::widget::Widget::step()+0x36) 5: ./libRack.so(rack::window::Window::step()+0x388) 4: ./libRack.so(rack::window::Window::run()+0x28) 3: ./Rack(main+0xec2) 2: /lib/x86_64-linux-gnu/libc.so.6(+0x23a90) 1: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x89) 0: ./Rack() [0x404319]

baconpaul commented 10 months ago

Can you give me any more information about what you were doing when this crash happened? Thanks!

ContemporaryInsanity commented 10 months ago

Just instantiated a Twist, that's all, not reliably reproducible but has happened a few times this last week.

baconpaul commented 10 months ago

Ok thanks! I’ll take a look. I do have one thought

baconpaul commented 10 months ago

Hmmm at first I thought it was the same thing as https://github.com/surge-synthesizer/surge/commit/9bb723916f0d883afe858cf0bae6facee2ed2588 which is fixed at head, but when i roll back i also don't get a crash

i duplicated a set of 10 twists 10 times and didn't see a crash and also looked at the code.

So can I ask a couple of favors

  1. If you use the nightly (which I'm about to tag as 2.2.2 so you could also use that) do you still get the crash?
  2. Is your machine particularly fast? or slow? or loaded when this happens? I reviewed the code path though to make sure everything is set up
  3. Do you have a default preset for twist which is different htan the default? Anything like that?

Thanks for your help! I'm going to push 2.2.2 with this still open since there's other fixes I want out, but lets keep poiking.

ContemporaryInsanity commented 10 months ago
  1. I'll grab it and have a play tonight / tomorrow.
  2. i7-4790k, only other things running of note, chrome, mixbus. Low CPU load ~30%.
  3. Just the default.
baconpaul commented 10 months ago

Thanks!

baconpaul commented 9 months ago

Just checking if you still see this at 2.2.2 / head? Thanks as always!