Oscillator waveform can go way past top/bottom of the display in some cases

surge-synthesizer / surge

Synthesizer plug-in (previously released as Vember Audio Surge)

https://surge-synthesizer.github.io/

GNU General Public License v3.0

3.13k stars 400 forks source link

Closed mkruselj closed 3 years ago

mkruselj commented 3 years ago

For example, with Classic oscillator:

Or it can also happen with WT oscillator quite often, especially if you use Saturate and Formant.

Solve by adding cliprects after the top and bottom lines of the display. Pray VSTGUI doesn't screw us over on Linux.

K0rrid0r commented 3 years ago

will those cliprects affect the sound or was this just visual?

baconpaul commented 3 years ago

just visual

mkruselj commented 3 years ago

Reopening since the PR was reverted. JUCE will save us here. Again 🙂

mkruselj commented 3 years ago

Moving to XT.

mkruselj commented 3 years ago

XT deals with this properly, so closing the issue!