search

surge-synthesizer / surge

Synthesizer plug-in (previously released as Vember Audio Surge)
https://surge-synthesizer.github.io/
GNU General Public License v3.0
3.08k stars 395 forks source link

Implement a voice pitch modulator as alternates to high low key scene modulators and voice keytrack #4286

Open mkruselj opened 3 years ago

mkruselj commented 3 years ago

For consistency with the polyphonic keytrack modulator. This will enable nice sound design tricks, for example emulating duophonic synthesizers like ARP Odyssey, and so on.

baconpaul commented 3 years ago

Two quick Q on this

So this is the High/Low/Latest scene modulator right? And you want it to be voice based for playing voice?

This will break existing patches. Do we want to add two flavors of H/L/Lt (a 'keyboard' version and a 'voice' version? the keyboard version being what we have today and the voice version being what you want) and map them as alternates?

mkruselj commented 3 years ago

They should still be scene level/monophonic modulators, but they should respect portamento options whenever the output value of the modulator changes. Agreed they could be alternates due to patch breaking risk.

I don't recall if these modulators also respect pitch bend or not. If they aren't, they should too.

baconpaul commented 3 years ago

Indices not alternates This one is annoyingly tricky though. It’s basically a completely different implementation to have porta since that is a feature of playing voices rather than of keys pressed. so I’ll add indices to these trackers and do a second impl

baconpaul commented 3 years ago

Basically you have highest key and pitch of highest sounding voice. Portamento bend and MPE make those different things

baconpaul commented 3 years ago

Too hard. Pushing out of milestone and reverting.