surge-synthesizer / surge

Synthesizer plug-in (previously released as Vember Audio Surge)
https://surge-synthesizer.github.io/
GNU General Public License v3.0
3.08k stars 394 forks source link

KVR Request for More AirWins #6114

Closed baconpaul closed 2 years ago

baconpaul commented 2 years ago

https://www.kvraudio.com/forum/viewtopic.php?p=8420895#p8420895

Lets take a look at this list and choose a yay/nay on them and sweep them if easy

Haven't Evaluated

YAY

NAY

mkruselj commented 2 years ago

YAY (-> to which category):

ChromeOxide -> Tape DubSub, DubCenter ->Filter (although these also generate a signal through octave dividing...) FireAmp -> Saturation and More GlitchShifter -> new category, Pitch NonlinearSpace -> Ambience Pafnuty -> Filter PowerSag -> Saturation and More TapeDust -> Noise ToVinyl4 -> Lo-Fi

Others are NAY.

baconpaul commented 2 years ago

on it

baconpaul commented 2 years ago

pafnuty has too many params. knocking that one out.

mkruselj commented 2 years ago

Doh, off by one param!

TBH we could remove the 12th param manually, leaving only 2nd-12th harmonics to play with?

baconpaul commented 2 years ago

I guess I could just leave it fixed at default sure. I’ll look. Got the rest of them in

mkruselj commented 2 years ago

I'd temporarily comment out the code relating to 13th harmonic in the DSP (so that it doesn't do anything), but let's see how feasible is that. I can jump into that part of code after it's in.

baconpaul commented 2 years ago

Right so that's what I did; basically knock out harms 12 and 13. (we get 11 fx params but one is burned for the type so we only get 10 aw params).

Once I merge 6116 the only work left is a labels review and also units/bipolar/discrete sweep for these four

GlitchShifter NonlinearSpace DubSub, DubCenter

which are a bit annoying so i didn't do them this morning (the unit display work that is; the actual fx are in place)

mkruselj commented 2 years ago

DOH I forgot the AW Type parameter.

XT2 can't come soon enough. 😀