search

surge-synthesizer / surge

Synthesizer plug-in (previously released as Vember Audio Surge)
https://surge-synthesizer.github.io/
GNU General Public License v3.0
3.15k stars 400 forks source link

Apple Silicon Logic Native: Key Focus Permanently Lost after Zooming #6154

Closed jcampbellcodes closed 2 years ago

jcampbellcodes commented 2 years ago

Bug Description: When you resize the GUI in Logic (native M1 only), key presses no longer go to the plug, only to the DAW. This means for example you can no longer search presets using the Surge preset manager, and if you hit delete during this time, you may accidentally delete your tracks etc.

Surge XT Version Version: Surge XT 1.0.1.60228e8 Build: 2022-01-31 @ 16:53:52 on 'Mac-1643647381380.local/pipeline' with 'AppleClang-12.0.0.12000032' using JUCE 6.1.2 System: macOS 64-bit AU on Apple M1 Host: Apple Logic @ 44.1 kHz

Reproduction Steps: Steps to reproduce the behavior:

  1. Open Surge in Logic M1
  2. Try to enter text in the preset search bar; note that it works as expected
  3. Use the Zoom option in the menu to resize the GUI
  4. Try again to enter text in the preset search bar (or any other key shortcut). Note that no key presses make it to Surge, they all pass through straight to the DAW

Expected Behavior: Key presses should go to the plug in focus; for instance if you have selected the preset search bar, you should be able to enter text in it.

Workaround: Close and reopen GUI

Computer Information (please complete the following!): System: macOS 64-bit AU on Apple M1 Host: Apple Logic 10.7.3 @ 44.1 kHz

baconpaul commented 2 years ago

So I can confirm this in 10.7.4 also on an M1.

I have absolutely no idea what to do about it

But I can confirm it.

Lemme try asking on the juce forums if nothing comes to mind.

baconpaul commented 2 years ago

Yeah OK so Surge XT AU in Reaper doesn't do this

and Pianoteq AU in Logic does the exact same thing (rezoom and key focus is lost)

This is almost definitely a logic bug in their window reparenting on M1. I have no idea how to report that to apple but I can ask the juce team if maybe they know.

I don't think there's a surge fix to be done here. Will keep this open to track the conversations which may arise though.

jcampbellcodes commented 2 years ago

Thanks Paul! I made a forum post on the JUCE forum as well, I've since repro'd with a few other plugs (Waves, UAD, Arturia) all in Logic M1 only. No idea how to report to Apple but really hoping they fix it...

https://forum.juce.com/t/bug-m1-apple-silicon-keyboard-focus-lost-permanently-in-logic-when-plugin-is-resized/51292

baconpaul commented 2 years ago

Yeah OK this is definitely neither a surge nor a juce bug. A non-surge non-juice plugin I have also demonstrates the problem.

I'll update my findings over at juce forum but this is an LPX bug. I'll close this issue here.