Resizability for the FX plugin

surge-synthesizer / surge

Synthesizer plug-in (previously released as Vember Audio Surge)

https://surge-synthesizer.github.io/

GNU General Public License v3.0

3.08k stars 394 forks source link

Resizability for the FX plugin #6267

Closed mkruselj closed 2 years ago

mkruselj commented 2 years ago

Let's see if this is feasible in time for 1.1. Here's a list of things to do:

[x] Hide the JUCE triangle in the corner just like we do for Surge XT
[x] Implement aspect ratio constrainer, with minimum zoom level (75% of the current default size?)
[x] Add zoom options to the menu
[x] Make zoom options actually work
[x] Saving and loading the set zoom level to user prefs
[x] Use the same keyboard shortcuts that Surge XT does by default

baconpaul commented 2 years ago

@mkruselj I'm debating keeping this code in place but toggling the default back to (false, false) for 1.1.0 and making this a 1.1.n - your comments or thoughts?

mkruselj commented 2 years ago

Hmm, any specific reason for doing that? It seemed to work just fine (including saving default zoom level) when I tested it, so it seems production ready (minus kbd shortcuts). We can leave kbd shortcuts for 1.1.n but to me it looks good to ship, unless you have an objection. Either way we go is fine with me tho.

baconpaul commented 2 years ago

Oh OK I was waiting for feedback from you which I thought would be a bunch of 'i hate it in this way or that way'

if you are happy with current and just want keyboard shortcuts I'll get this one closed today :)

mkruselj commented 2 years ago

WOOHOO!