search

surge-synthesizer / surge

Synthesizer plug-in (previously released as Vember Audio Surge)
https://surge-synthesizer.github.io/
GNU General Public License v3.0
3.08k stars 394 forks source link

CLAP -> MIDI controller stuck notes. #6470

Closed STOP63 closed 2 years ago

STOP63 commented 2 years ago

CLAP version 24d4a4b Reaper 6.64+dev0803 Stuck midi notes when a MIDI controller keyboard is played. No issue with VST3i version

mkruselj commented 2 years ago

Cannot confirm over here locally.

STOP63 commented 2 years ago

I know from Reaper forum but did you test with a real keyboard? Mine are M-Audio Axiom61 and a Roland A-34. No issue with VST3 plugin.

mkruselj commented 2 years ago

Yes, tested with Korg nanoKEY Studio and NI S49mk2. All works.

baconpaul commented 2 years ago

You don't happen to have surge in MPE mode do you @STOP63

STOP63 commented 2 years ago

What is MPE mode?

Just want to be clear. I drag Surge XT VST plugin in Reaper everything is default and it work when I play with my keyboard.

I close Reaper

I re-open Reaper I drag Surge XT CLAP plugin in Reaper everything is default and all the notes that I play on the keyboard get stuck.

Same with Reaper portable.

baconpaul commented 2 years ago

Right there is a light button next to patch browser that says “mpe” between zoom and tune. is it lit up in the clap in reaper?

can you record and send an rpp file?

and are all your notes on the same midi channel?

appreciate the report - sure we can solve it

STOP63 commented 2 years ago

OK MPE not activated but i tried it on and same issue.

I tried USB AXIOM61 > channel 1 only and same issue.

Here is a rpp file surge_xt.zip

mkruselj commented 2 years ago

Looks like somehow release velocity data is corrupted (see Reaper's MIDI event list). It should say 0 instead of --. Or maybe Reaper isn't handling release velocity towards CLAP very well. Forwarding your RPP to Reaper devs.

Considering sustain pedal works fine over here (and in Bitwig), I'm not sure if this is on our side to fix.

STOP63 commented 2 years ago

Never mind the sustain pedal, I just mention the sustain pedal (on the dev reaper thread forum) to explain what it sound like. I used the term like if the sustain pedal was applied.

mkruselj commented 2 years ago

Well ok, even regularly played notes, works just fine here. I can't get any stuck notes...

baconpaul commented 2 years ago

Yeah I’m traveling today but let me load the rpp and see what it actually sends surge! That should help us triangulate

which reaper by the way? Still the 0803 one?

STOP63 commented 2 years ago

Yes, still the 0803 one.

mkruselj commented 2 years ago

From schwa: "that is most likely the 0x90 + velocity=0 note-off protocol, which should be handled for the next REAPER build".

Closing since it's not on our side.

STOP63 commented 2 years ago

Maybe but I have to mention that the CLAP version of "ODIN II" work fine.

STOP63 commented 2 years ago

It work! +dev0804