search

surge-synthesizer / surge

Synthesizer plug-in (previously released as Vember Audio Surge)
https://surge-synthesizer.github.io/
GNU General Public License v3.0
3.08k stars 394 forks source link

Undo doesn't track waveform selection #6581

Closed treelimbjim closed 2 years ago

treelimbjim commented 2 years ago

Waveform selection isn't tracked by Undo/

Surge XT Version Version: Surge XT 1.0.1.60228e8 Build: 2022-01-31 @ 16:53:52 on 'Mac-1643647381380.local/pipeline' with 'AppleClang-12.0.0.12000032' using JUCE 6.1.2 System: macOS 64-bit AU on Apple M1 Host: Apple Logic @ 96.0 kHz

Reproduction Steps:

  1. Loaded Bass IV preset
  2. Poked around to adjust envelope
  3. Got curious about different waveforms. Tried out a few.
  4. Hit Undo in LP wrapper. Began unstacking envelope slider positions while waveform stayed in last selection.

Expected Behavior: Please don't tell me to RTFM; that its an expected behavior.

Computer Information (please complete the following!):

Additional Information: Add any other context about the problem here.

baconpaul commented 2 years ago

Hi

So Logic Pro can only undo parameter changes, and wavetables aren't parameter exposed at the edge. Similarly the LP undo can't undo anything like modulation depths, mseg snap points, formulae so on. This is why many plugins end up having to implement their own internal undo mechanism (especially since Logic is one of the better daws in this regard).

But In Surge XT 1.1 we implemented that mechanism, and when I use it, wavetables undo correctly using it.

There's practically no way to express something like a wavetable as a stable AU parameter; the range and value is not stable over sessions. But if you upgrade to 1.1 you will be able to undo all features of the synth whether they are exposed as parameters or not.

So while I guess we are, to your delight, not inviting you to RTFM, we are inviting you to RTFCLAU (read the fine change log and upgrade) so you can get this feature.

Thanks!

treelimbjim commented 2 years ago

It became apparent that I should have RTFM BEFORE loading and firing the Bug Gun. I reacted out of emotion.

Thank you.

I could be out on a limb.

On Aug 30, 2022, at 12:44 PM, Paul @.***> wrote:

 Closed #6581 as completed.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

baconpaul commented 2 years ago

No problem! Hope you enjoy making music with surge, and if there is any missing undo in 1.1.1 its a real bug so please let us know. We think we got it all but it is tricky.