Rename user preset appears database lock error

[ghost]

1. Rename a user preset and save
2. The error appears: PatchDB - Loading Favorites SQL Error[5]. Database is locked (This Error appears two times immediataly)
3. After confirm, the preset is finally renamed
4. If i want to perform now the following i got the same error: PatchDB - SQL Error[5]. Database is locked (without the "Loading Favorites"), and this time up to 20+ times immediataly, that i have to confirm now
   • save a new preset, delete a preset, favorite a preset
   • again after confirming all the errors, the action was performed, and i see the favorite, the preset is deleted or a new is created!
   • Refresh patch browser doesn't help
   • Restart the surge standalone session or the DAW host helps and all actions can performed without an error as long as no preset rename is performed! Then the error appears again for all the actions above!

• Version: Linux x64 Verison 1.1.2, 1.2.0, and the nightly downloaded on 2023.04.18

• Plugin Type: VST3, Clap, LV2 in Reaper and Standalone

  • OS: openSUSE Tumbleweed 20230413, amd64
  • Host: Reaper 6.73
• Another User has the same issue in Arch Linux too.

[baconpaul]

I was able to reproduce this on ubuntu with the standalone.

[baconpaul]

Ahh the problem is that rename == save then delete the save happens and rebuilds the database so then the delete happens and also rebuilds the database so we have dueling rebuilds

annoying. need to ponder.

[mkruselj]

Can we not save then delete and only then update database? If needed thread a parameter to save function to skip database rebuild, defaulted to true?

[baconpaul]

Yes but I think that’s not it anyway

also that’s an annoying code change for an annoying reason

[baconpaul]

OK I've found it. It was slightly different than I thought

basically a threading error. A couple of defensive fixes coming in next 30 minutes.

[baconpaul]

OK all merged.