surge-synthesizer / surge

Synthesizer plug-in (previously released as Vember Audio Surge)
https://surge-synthesizer.github.io/
GNU General Public License v3.0
3.15k stars 400 forks source link

FX bypass via OSC #7309

Closed Andreya-Autumn closed 11 months ago

Andreya-Autumn commented 12 months ago

Bypass FX would be a useful thing to add. This would need an additional boolean address per FX slot.

It would also be useful to be able to clear an FX slot. My first thought was that sending /param/fx/*/1/type = 0 should clear it. This address has type "contextual" in the spec (and I've misplaced my Touchosc somehow lol) so I don't know, perhaps it already does this already? If so, let's just clarify that in the spec, and otherwise let's perhaps make it so?

baconpaul commented 12 months ago

the clear action internally is same as set to 'fxt_off' which is 0, yeah

mkruselj commented 12 months ago

So yes then we just need the bypass action in the spec.

pkstone commented 12 months ago

the clear action internally is same as set to 'fxt_off' which is 0, yeah

I've confirmed that the OSC message '/param/fx/a/3/type 0' does indeed clear the associated effect slot.