surge-synthesizer / surge

Synthesizer plug-in (previously released as Vember Audio Surge)
https://surge-synthesizer.github.io/
GNU General Public License v3.0
3.13k stars 400 forks source link

Formula LFOs behave differently if they have more than one output #7531

Closed butscher closed 7 months ago

butscher commented 7 months ago

Bug Description: I tried to create some kind of vocal sounds by filtering noise through an equalizer added to the insert FX chain. It should emphasize two frequencies from this Wikipedia table.

To allow switching between the vowels, I wrote lua scripts. In the attached patch Formant Filter Basic_bug.zip the desired vowel is selected by Macro 1 (named "Vowel Select").

In scene A, S-LFO1 contains code to calculate the first frequency for the equalizer, S-LFO2 code for the second frequency.

In scene B, S-LFO1 contains code to calculate both frequencies.

All the scripts are nearly identical except for the final output. All other settings are identical between the scenes, so theoretically both scenes should generate the same sound but they don't do this.

Surge XT Version

Reproduction Steps: Steps to reproduce the behavior:

  1. Load the attached patch
  2. Play a note with scene A set
  3. Compare to same note with scene B

Expected Behavior: Same sound generated by both scenes.

Computer Information (please complete the following!):

baconpaul commented 7 months ago

OK can definitely reproduce. And it does look weird.

We're looking. Thanks for the excellent report.

baconpaul commented 7 months ago

oh for goodness sake. slfo just ignores routing index. that bug has been there forever. Stay tuned.

baconpaul commented 7 months ago

This is fixed in #7533 and will be in a nightly build later tonight (probably around 8PM US Eastern at the latest). We're gonna make a mini 1.3.2 release also which includes the fix but that's probably not till the weekend. You can always grab a nightly https://surge-synthesizer.github.io/nightly_XT/

Thank you for the excellent bug report. Really top rate GitHub issue reporting. Appreciated.