Mod List Unipolar Values

[Jxp955]

Bug Description: Using Velocity (or any Unipolar LFO) to modulate any of the Envelope parameters, or Filter Cutoff, seems to lead to incorrect values in the mod list. Bipolar modulations seem to always work.

Surge XT Version Surge XT 1.3.1.4b53827

• Version: 2024-02-06 @ 15:34:52 on 'fv-az527-661/pipeline' with 'MSVC-19.37.32826.1' using JUCE 7.0.5
• Plugin Type: VST3
• Bitness: 64-bit

Reproduction Steps: Steps to reproduce the behavior:

1. Click Velocity modulator, or a LFO and set to Unipolar.
2. When green, change some of the EG or filter cutoff values.
3. When done click on the mod List.
4. The numbers don't seem to add up.

Expected Behavior: The math on bipolar LFO's seems to be fine. The actual modulation may work, it could be just the numbers.

Screenshots: Notice on both Attacks the 0 plus a value still equals 0.

Computer Information (please complete the following!):

• OS: Windows 10
• Host: Reaper
• Version: 7.12

Additional Information: Add any other context about the problem here.

[baconpaul]

Oooh thanks.

[baconpaul]

Right theres two problems here

1. The envelope time modulation depths are shown in seconds not milliseconds
2. The 'target endpoint' indeed shows incorrectly in unipolar mod mode

Here's a clear example. Let me see if i can fix it today.

[baconpaul]

The first is the incomplete implementation in 12aa6a05

if the base value is below the millisecond value and ParamDisplayFeatures::kSwitchesFromSecToMillisec is true, show the modulation depth in milliseconds.