search

surge-synthesizer / surge

Synthesizer plug-in (previously released as Vember Audio Surge)
https://surge-synthesizer.github.io/
GNU General Public License v3.0
3.01k stars 385 forks source link

Prettify host context menu for Reaper #7620

Closed mkruselj closed 2 months ago

mkruselj commented 2 months ago

Removes repeated parameter name in ugly square brackets in Reaper case.

This unfortunately had to modify the semantics of SurgeSynthEditor::modifyHostMenu() to work with a copy rather than a direct reference, since I didn't see a way to remove a menu entry when working with juce::PopupMenu::MenuItemIterator.

baconpaul commented 2 months ago

oooh lemme make sure this is safe before we merge OK? I don't know the lifetime of all the objects and am not sure the copy preserves them.

mkruselj commented 2 months ago

Sure!