search

surge-synthesizer / surge

Synthesizer plug-in (previously released as Vember Audio Surge)
https://surge-synthesizer.github.io/
GNU General Public License v3.0
3.17k stars 400 forks source link

Effects section slider values will incorrectly change when left-clicked (without movement) #7630

Open gonk23 opened 7 months ago

gonk23 commented 7 months ago

Bug Description: Surge XT VST3 effects section slider values will incorrectly change when left-clicked (without movement). The standalone version of Surge XT on the same computer doesn't appear to have this issue. Problem observed on both Windows and macOS.

Surge XT Version

Reproduction Steps:

Expected Behavior: The slider values should not change when left clicking on them without movement. The slider value should correspond to its position.

Computer Information (please complete the following!):

baconpaul commented 7 months ago

I wonder if this is live sending us automation we don’t expect. Is surge in a latch mode in live or some such when you do this? Do you see it in any other environment (if you have one)?

gonk23 commented 7 months ago

I'm not aware of any type of latch mode being activated. It's immediately after loading Live.

I tried all the other sliders in the synth and they seem fine. It's only the sliders in the "FX INPUT" section that have this weird behaviour.

On Windows, I've just tried Hermann Sieb's VSTHost (1.57 64-bit) and Reaper (7.15 64-bit), and they don't seem to have this problem, so it's looking like it's a Live specific problem at the moment.

Back in Live, I tried TAL-NoiseMaker and Dexed VST3 plugins and their knobs/sliders don't show any weird behaviour.

baconpaul commented 7 months ago

Thank you for the accurate report at least!

We will try and look and replicate!

gonk23 commented 7 months ago

Thanks for looking at it Paul.

It's obviously not really a problem in practice because one tends to only click on a slider when they want to change it anyway.

baconpaul commented 4 months ago

Discord user OfteN reported similar problem just at load and save time

Grunwaldt commented 4 months ago

I'm the user "OfteN" in discord. The problem I had seem to get fixed disabling MPE from Ableton. It was resetting some of the slider controls to the left for the delay FX, also chorus mix to the right. On patch load, I think it doesn't happen if you disable the MPE feature for the plug-in from Ableton, will confirm tomorrow and say if that fixes it

Grunwaldt commented 4 months ago

I just launched Surge XT in Ableton and disabled MPE in the host device plug-in box, and the problem doesn't happen when I load a patch. If I get more info about it will post...

My system: Windows 10 Pro fully updated Surge XT 1.3.2 vst3, 64 bits Ableton Live 12.0.10 Standard

mkruselj commented 4 months ago

I wonder if you might have an accidental MIDI learn to some of the FX sliders. MPE uses CC 74 for Timbre, so that might be it...

Grunwaldt commented 4 months ago

I didn't use any MIDI learn ever, and just checked and those sliders doesn't have a CC assigned to them, but thanks for thinking about what the issue would be...

Grunwaldt commented 4 months ago

Oh it just happened without MPE enabled, on the delay Mix, went to 0 by itself when switching between patches. There is obviously a bug on it

EDIT: I'm experimenting with the problem and it looks it saves the patches right, but there is a problem on loading. Because i started surge as a fresh instrument in Ableton, disabled MPE and loaded a patch that had the problem when i switched by the old instance of surge, and it loaded fine, not with the "Mix" at 0. That was when i switched patch on original instance of Surge XT