search

surge-synthesizer / surge

Synthesizer plug-in (previously released as Vember Audio Surge)
https://surge-synthesizer.github.io/
GNU General Public License v3.0
3k stars 385 forks source link

FM2 osc and Freq Shifter param definition fixes #7651

Closed mkruselj closed 1 month ago

mkruselj commented 1 month ago

Extend mode now actually works for FM2 M1/2 Offset. Increase streaming version (patches with sv < 24 will always load with M1/2 Offset extend disabled to retain their sound).

Frequency Shifter's Range was mistakenly showing 10x smaller values in all the displays. Fixed this by adding a new ctype (to discern it from FM2 oscillator's M1/2 Offset parameter, and doing everything necessary to ensure proper value display and conversion from string input etc.

mkruselj commented 1 month ago

@baconpaul Won't merge until you have a look! I think it's all good but better be safe than sorry.

baconpaul commented 1 month ago

It seems freq shift could still be linear just with different coefficients and then we could avoid all the code which does per type formatting no? I will take a closer look when not in phone but don’t understand why we can’t just use linear with range info for this