search

surge-synthesizer / surge

Synthesizer plug-in (previously released as Vember Audio Surge)
https://surge-synthesizer.github.io/
GNU General Public License v3.0
3.1k stars 395 forks source link

Support builds on alternative c libraries other than glibc for linux #7676

Closed catarial closed 3 months ago

baconpaul commented 3 months ago

features.h is not a part of the standard and you included it, breaking all the builds. I think if you remove that and re-push we will see a clean CI.

baconpaul commented 3 months ago

Oh my other question. Will GLIBC be defined in, say, a mingw compile? And will that have exec info?

catarial commented 3 months ago

Oh my other question. Will GLIBC be defined in, say, a mingw compile? And will that have exec info?

https://stackoverflow.com/questions/6394512/standard-c-library-in-mingw

"MinGW does not build against glibc, it builds against msvcrt. As such, it uses libmsvcrtXX.a instead."

It seems like it doesn't

catarial commented 3 months ago

features.h is not a part of the standard and you included it, breaking all the builds. I think if you remove that and re-push we will see a clean CI.

should I wrap in a #if LINUX that header is needed to determine if glibc is being used

catarial commented 3 months ago

features.h is not a part of the standard and you included it, breaking all the builds. I think if you remove that and re-push we will see a clean CI.

should I wrap in a #if LINUX that header is needed to determine if glibc is being used

actually I was wrong about that, Ill remove features.h