surge-synthesizer / surge

Synthesizer plug-in (previously released as Vember Audio Surge)
https://surge-synthesizer.github.io/
GNU General Public License v3.0
3.16k stars 399 forks source link

Upgrade to SIMDe v0.8.2 #7693

Closed mr-c closed 4 months ago

baconpaul commented 4 months ago

Thanks! I see you are a maintainer and contributor on simde, so thank you for your work on this invaluable package.

Anything particular we need to look out for with this upgrade? Our CI does pretty good tests, but we have a very broad deployment pattern.

But anyway I'll merge and we can find out! Appreciate you pushing.

mr-c commented 4 months ago

Thanks! I see you are a maintainer and contributor on simde, so thank you for your work on this invaluable package.

You are very welcome, I appreciate that!

Anything particular we need to look out for with this upgrade? Our CI does pretty good tests, but we have a very broad deployment pattern.

Hmm.. It is a big version jump! Previously surge was using a development snapshot of version 0.7.1; since then there have been 1158 files changed, 491377 insertions(+), 17657 deletions(-)

https://github.com/simd-everywhere/simde/compare/3c6b4cb8bd11cc253abc2cfec06310839673fc4e...71fd833d9666141edcd1d3c109a80e228303d8d7

Here are the changelogs

Broadly speaking, many new intrinsics supported, many new optimized implementations, lots of bug fixes and compiler-specific workarounds :-)

baconpaul commented 4 months ago

Well that all sounds good. And your CI is definitely more comprehensive than ours!

I'll just flag to our dev group that the upgrade happened in case they see something. And will also poke at that riscv issue we've been chatting on before our next release.

Thank you again! quite literally because of simde, surge was a universal macOS plugin before Logic Pro was a universal macOS host!