search

surge-synthesizer / surge

Synthesizer plug-in (previously released as Vember Audio Surge)
https://surge-synthesizer.github.io/
GNU General Public License v3.0
3.14k stars 399 forks source link

Resolve int16 wt interpretation documentation and comparability #7694

Closed abique closed 3 months ago

abique commented 3 months ago

Hi,

According to the specification, if you want to encode 16 bits samples, you need the flags = 0x0C while it currently sets flags = 0x04 which is for 15 bits samples.

Reference: https://github.com/surge-synthesizer/surge/blob/main/resources/data/wavetables/WT%20fileformat.txt#L11

When looking at https://github.com/surge-synthesizer/surge/blob/main/scripts/wt-tool/wt-tool.py#L43

The bug seems to be here: https://github.com/surge-synthesizer/surge/blob/94c8c5b02fb2dadf62dae70a146d67ae487309a1/scripts/wt-tool/wt-tool.py#L43

Cheers, Alex

baconpaul commented 3 months ago

OK great. Did you happen to see the windows wavetable path?

abique commented 3 months ago

OK great. Did you happen to see the windows wavetable path?

C:\Users\bique\AppData\Local\Bitwig Studio\installed-packages

abique commented 3 months ago

It seems that the specification file for the .wt file format hasn't been entirely updated yet, it is missing:

mkruselj commented 3 months ago

Updating it!

baconpaul commented 3 months ago

Ahh I was going to do this along with the bitwig paths once you shared the bitwig resource path on windows with me Alex! Do you happen to have that? Or I can ask a bitwig windows user if it’s not easy to see from the code

abique commented 3 months ago

Ahh I was going to do this along with the bitwig paths once you shared the bitwig resource path on windows with me Alex! Do you happen to have that? Or I can ask a bitwig windows user if it’s not easy to see from the code

C:\Users\bique\AppData\Local\Bitwig Studio\installed-packages

baconpaul commented 3 months ago

Ahh and see it is here now. Cool let’s leave this open until I modify storage

baconpaul commented 3 months ago

OK to avoid confusion I opened that up as a separate FR in #7720 and will now close this as done. Good stuff!