In the new tests for skipped notes, the "gaps" tests assert the modulo scale positions as midi notes - I suspect a typo:
for (int k = 0; k < 128; ++k)
{
int i = k % 12;
bool isOn = i == 0 || i == 2 || i == 4 || i == 5 || i == 7 || i ==
9 || i == 11;
INFO(k << " scpos=" << i << " isOn = " << isOn);
REQUIRE(t.isMidiNoteMapped(i) == isOn);
}
was probably intended to test
REQUIRE(t.isMidiNoteMapped(k) == isOn);
if so, there are similar typos in
SECTION("Gaps in the Maps")
SECTION("Gaps in the Maps KBM Only")
SECTION("Tuning with Gaps and Interpolation")
Oh ha yeah that is a typo good find. It happens to work since I am testing against a keyboard model which has periodicity 12 but the test would break otherwise. Thank you.
In the new tests for skipped notes, the "gaps" tests assert the modulo scale positions as midi notes - I suspect a typo:
was probably intended to test
if so, there are similar typos in