search

surged20 / wjmais

Wildjammer: More Adventures in Space
MIT License
13 stars 6 forks source link

[BUG]Minor changes to ship items breaks them / editing items moves them to "cargo" #10

Closed UnoriginalDM closed 2 years ago

UnoriginalDM commented 3 years ago

When you make changes within ship items like change rarity, change equipment type, and many of the other fillable fields, the item will lose its type and no longer work properly within the ship sheet. Preferably, the DM should be able to control the type of item (module, hull, upgrades, weapons) on the details page. image image

EDIT: I am also noticing that if you open and edit an item WITHOUT changing anything and close the item it moves into cargo as well. image image image

I am using the latest 5e 1.5.2 and latest WJMAIS.

surged20 commented 2 years ago

Thanks for the report. This bug should be fixed in release 0.3.1. Let me know if you still have this issue.

UnoriginalDM commented 2 years ago

OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOH SNAAAAAAAAAP MY PLAYERS ARE GONNA BE PUMMMMMPPPPEDDD THAT SPELLJAMMER SHIP BATTLES ARE BACK ON

But for real I will keep you posted. Thanks for your hard work.

UnoriginalDM commented 2 years ago

Hey so I finally had sometime to mess around and it appears to still be happening for any items that are Modules, Hulls, or Upgrades.

surged20 commented 2 years ago

Hey so I finally had sometime to mess around and it appears to still be happening for any items that are Modules, Hulls, or Upgrades.

Ok, first off, thank you for taking the time to provide detailed screenshots that is very helpful. Unfortunately I just walked through these examples again and can't recreate it. I'm on Core 9.255, dnd5e 1.5.7, and wjmais 0.3.1.

Can you do the following:

  1. confirm core, system, and wjmais versions
  2. open your browser developers tools with F12 and note any errors there
  3. export a broken ship and attach to this issue so I can inspect it. 2022-03-11_16-07
surged20 commented 2 years ago

Hey so I finally had sometime to mess around and it appears to still be happening for any items that are Modules, Hulls, or Upgrades.

Ignore my request. This is my bad. The fix commit didn't get pushed up but the changelog did. The latest release (0.3.2) now contains the fix I've been using so please update and try again.

UnoriginalDM commented 2 years ago

Hey happy to report that the issue is fixed. Thanks a bunch dude.

surged20 commented 2 years ago

Happy to have it addressed finally, thanks for confirming.