search

surgical-robotics-ai / surgical_robotics_challenge

Interactive Robot Assisted Suturing Simulation
55 stars 43 forks source link

Joint errors model #47

Closed nhatleminh1997 closed 2 years ago

nhatleminh1997 commented 2 years ago

I noticed that in line 72 file joint_errors_model.py for initializing joint error models

rand_val = 2. * random() - 1.

will always give positive value for rand_val and therefore for the joint errors. I think you might want to flip the sign there.

adnanmunawar commented 2 years ago

Hi Nhat,

The range of rand_val = 2. * random() - 1. should be between [-1.0, 1.0]. Checkout this snippet: https://onecompiler.com/python/3y24dpjhh

nhatleminh1997 commented 2 years ago

You are right. I made a mistake while testing it.