Closed JackHaoyingZhou closed 4 months ago
Merge FK&IK method into the psmKinematic solver class; create a class variable for the teleoperation scaling factor; in the later future, create a json file to load all tools; move the grasp needle into utility or examples
Revision done, clean code, ready to merge
Wait for asset so that we can do the final merge
Hi Adnan/Jack,
I went over Jack's PR and had some small comments and possible changes.
Currently we copy-pasted the JSON files from the dVRK into the SRC repository, but not all the values from these JSON files are used. Only the DH parameters are read from these files. Should we try to simplify them? That is only keeping the values that are used inside the SRC code base.
Add a readme on the config folder indicating that 4200006 is an SI large needle driver and that 4000006 is a classic large needle driver.
Maybe change the names of kinematic files to include the AMBF_large_needle_driver.json
. This way we make sure people know these are only for the simulation. Also, specify in the readme which DH parameters are different from the ones in the DVRK repository.
@adnanmunawar and @JackHaoyingZhou a small change before submitting the PR:
mtm_psm_pair_teleop_400006.sh
and mtm_psm_pair_teleop_420006.sh
, but the script to run the environment are run_env_simple_instruments.sh
and run_env_real_instruments.sh
. I would make sure these names consistent.Probably users won't know that simple instruments are based on the 400006 instrument.
The pull request contributes to the following points:
Need to do: