surgical-robotics-ai / surgical_robotics_challenge

Interactive Robot Assisted Suturing Simulation
59 stars 45 forks source link

Add and update the scripts for the new instrument, kinematic data record & replay #96

Closed JackHaoyingZhou closed 4 months ago

JackHaoyingZhou commented 5 months ago

The pull request contributes to the following points:

  1. make the scale of everything to be 1:1 (change linear scaling factor from 10 to 1).
  2. add kinematic data recording and replaying scripts, correspond the replay scaling factor with the unit conversion information.
  3. add an additional argument called "tool_id" to address kinematics and teleoperation scripts for different surgical instrument

Need to do:

  1. add new models (include new suturing needle, 3d med phantom, new surgical instrument and etc)
  2. I only provide the closed-form FK, but I also have scripts for FK using screw theory, can add to the repository if required
  3. the scripts suppose to work with new models, will test after adding the new models.
JackHaoyingZhou commented 5 months ago

Merge FK&IK method into the psmKinematic solver class; create a class variable for the teleoperation scaling factor; in the later future, create a json file to load all tools; move the grasp needle into utility or examples

JackHaoyingZhou commented 5 months ago

Revision done, clean code, ready to merge

JackHaoyingZhou commented 5 months ago

Wait for asset so that we can do the final merge

jabarragann commented 5 months ago

Hi Adnan/Jack,

I went over Jack's PR and had some small comments and possible changes.

Future developments

jabarragann commented 4 months ago

@adnanmunawar and @JackHaoyingZhou a small change before submitting the PR:

  1. the teleoperation scripts names are mtm_psm_pair_teleop_400006.sh and mtm_psm_pair_teleop_420006.sh, but the script to run the environment are run_env_simple_instruments.sh and run_env_real_instruments.sh. I would make sure these names consistent.

Probably users won't know that simple instruments are based on the 400006 instrument.

  1. Revise all scripts that included FK and IK functionalities. There might be some broken scripts.