search

suriab / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

xcode generator errors if 2 gyp files have the same name (Duplicate ID). #114

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
See test "same-gyp-name" introduced in 
http://codereview.chromium.org/384146

If a gyp file references 2 other gyp files that have the same base name, 
the xcode generator errors with a message like:
Traceback (most recent call last):
  File "/home/piman/prog/extern/o3d/tools/gyp/gyp", line 18, in <module>
    sys.exit(gyp.main(sys.argv[1:]))
  File "/home/piman/prog/extern/o3d/tools/gyp/pylib/gyp/__init__.py", line 
432, in main
    generator.GenerateOutput(flat_list, targets, data, params)
  File 
"/home/piman/prog/extern/o3d/tools/gyp/pylib/gyp/generator/xcode.py", line 
1091, in GenerateOutput
    xcode_target_to_target_dict)
  File 
"/home/piman/prog/extern/o3d/tools/gyp/pylib/gyp/generator/xcode.py", line 
386, in Finalize2
    self.project_file.EnsureNoIDCollisions()
  File "/home/piman/prog/extern/o3d/tools/gyp/pylib/gyp/xcodeproj_file.py", 
line 460, in EnsureNoIDCollisions
    str(other._properties), self._properties['rootObject'].Name())
KeyError: 'Duplicate ID A8DB2BB9469196A9CD3EAEF3, objects "{\'children\': 
[<PBXReferenceProxy \'program2\' at 0x7f8d69550ed0>], \'name\': 
\'Products\', \'sourceTree\': \'<group>\'}" and "{\'children\': 
[<PBXReferenceProxy \'program1\' at 0x7f8d69550d10>], \'name\': 
\'Products\', \'sourceTree\': \'<group>\'}" in "all"'

Original issue reported on code.google.com by pimanttr3@gmail.com on 16 Nov 2009 at 2:12

GoogleCodeExporter commented 9 years ago

Original comment by thomasvl@chromium.org on 19 Jan 2010 at 2:12

GoogleCodeExporter commented 9 years ago 
This was fixed by noyau in gyp r1481. The test still fails since it can't find 
the generated executable though (it's in a subdirectory with xcode).

Original comment by thakis@chromium.org on 20 Sep 2012 at 9:45

GoogleCodeExporter commented 9 years ago 
I'm fixing this test in https://chromiumcodereview.appspot.com/10911280/

Can this bug be assigned to me so I can close it when I land the CL. Thanks.

Original comment by noyau@chromium.org on 20 Sep 2012 at 11:41

GoogleCodeExporter commented 9 years ago 
Can't assign to you if you're not a project member :/
Just let me know and I'll close.

Original comment by piman@chromium.org on 20 Sep 2012 at 4:38

GoogleCodeExporter commented 9 years ago 
Fixed by noyau in r1504

Original comment by thakis@chromium.org on 21 Sep 2012 at 4:55