search

suriab / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

Chrome libs variable has 15 copies of -lpthread #124

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
1) Generate a chrome/chrome.target.mk with gyp+make.
2) Look at the LIBS variable.
3) Giggle at the 17 instances of -lpthread.

Original issue reported on code.google.com by evan@chromium.org on 2 Dec 2009 at 11:29

GoogleCodeExporter commented 9 years ago 
Seeing as I pointed this out (Thanks for filing it Evan), I'll volunteer to 
take a
look at it.  No promises though: I'm still quite the noob.

Original comment by brye...@google.com on 2 Dec 2009 at 11:44

GoogleCodeExporter commented 9 years ago 
Having done some investigation, I do not think this is worth fixing right now.

There is a specific exception in gyp so that any items in a list that are 
prefixed by
"-" are not treated as singletons when merging lists.  This is a good thing: 
there
are some situations with some linkers where libraries may need to be listed 
more than
once.

Further, at least with GNU ld, there does not seem to be any appreciable 
slowdown
when linking with the extra libraries listed.

That said, I'm sure we can do better (it can't really be necessary to repeat 
"-lrt
-lpthread" a dozen times at the end of the libraries list) but it probably is 
not
worth fixing until we run into a linker that suffers from such a command line.

Original comment by brye...@google.com on 4 Dec 2009 at 4:03