suriab / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

link_settings isn't being propogated properly on (at least) linux #69

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. I have a target that looks something like this:

  'targets': [
    {
      'target_name': 'cg_libs',
      'type': 'none',
      'direct_dependent_settings': {
        'include_dirs': [
          '../../<(cgdir)/include',
        ],
      },
      'conditions': [
        [ 'OS=="linux"',
          {
            'link_settings': {
              'libraries': [
                "-l<(PRODUCT_DIR)/lib/libCg.so",
                "-l<(PRODUCT_DIR)/lib/libCgGL.so",
              ],
            },
          },
        ],
        # and so on, for each platform...

When the above is evaluated, the scons files for the dependents of this 
target do NOT contain link instructions for these two libs.

2. If I change the "link_settings" block to be called 
"direct_dependent_settings", then the link line contains the libs properly.

What is the expected output? What do you see instead?

I would expect that the first way works (and maybe even that the second way 
doesn't, so that there's only one way to do things).

I haven't tried this on Windows/Mac yet.

Original issue reported on code.google.com by gspen...@google.com on 21 Aug 2009 at 5:25

GoogleCodeExporter commented 9 years ago
Might be connected to this being a 'none' type target...?

Original comment by sgk@chromium.org on 21 Oct 2009 at 5:42

GoogleCodeExporter commented 9 years ago
My understanding is that direct_dependent_settings is the correct thing to do 
here.
Mark can probably confirm+close.

Original comment by evan@chromium.org on 26 May 2011 at 10:20

GoogleCodeExporter commented 9 years ago
I think that this is one reason people use 'type': 'settings' along with 
'link_settings'.

Greg, reopen if that doesn’t work.

Original comment by mark@chromium.org on 26 May 2011 at 11:16