surikov / webaudiofont

Use full GM set of musical instruments to play MIDI and single sounds or effects. Support for reverberation and equaliser. No plugins, no Flash. Pure HTML5 implementation compatible with desktop and mobile browser. See live examples.
https://surikov.github.io/webaudiofont/
GNU General Public License v3.0
891 stars 92 forks source link

Author attribution for commit d3d2959 #97

Closed mk-pmb closed 1 year ago

mk-pmb commented 1 year ago

Hi! Thanks for your updates to MIDIFile.js in https://github.com/surikov/webaudiofont/commit/d3d29592ce29d9aeb673515b9723e272b39ad7da (patch). I'd like to merge them back into upstream. At the time of that commit, the license seems to have been MIT (raw), but it doesn't state an author name, and neither did package.json at that time (raw).

With what name (and potentially contact info) would you like to be credited for that code?

If it's not too much effort, may I invite you to PR the relevant changes into my waf-addslide branch yourself? Commiting it yourself would probably be the best way to add you into upstream git history.

The commit description would be a good place to put a link to your repo also. A link to this issue would be appreciated as well. Example for your copying convenience:

Backport 2018-04-07 updates from surikov/webaudiofont

Original repo: https://github.com/surikov/webaudiofont
Solves https://github.com/surikov/webaudiofont/issues/97