suriyun-production / battle-io-docs

This is document for Battle IO project (https://www.assetstore.unity3d.com/#!/content/101113?aid=1100lGeN)
https://suriyun-production.github.io/battle-io-docs/
1 stars 0 forks source link

Team Death Match Ending on Start of Game #11

Closed jonmalave closed 4 years ago

jonmalave commented 4 years ago

It seems when you start a new team death match game everything works perfectly fine now since the last update. Although I notice if you exit a team death match before the game ends, and you return and start a new team death match the previous game score remains in memory.

We need to clear this out, so on exit of Team Death Match the client removes any team scores in memory before starting a new Team Death Match room.

Please see screenshots below for reference. In the first screenshot I set the Max Kills to 40, then on the second I set the Max Kills to 20, since the previous team scores past 20 already the game automatically ends on start.

error_01

error_02

jonmalave commented 4 years ago

Hi @insthync any update on this issue?

insthync commented 4 years ago

It might be because of Photon's bugs (That I've reported them https://forum.photonengine.com/discussion/comment/50506)

Not sure the update has been published or not, if not you may try import this package Photon_FixTeamsManagerNullReferences.zip

jonmalave commented 4 years ago

It might be because of Photon's bugs (That I've reported them https://forum.photonengine.com/discussion/comment/50506)

Not sure the update has been published or not, if not you may try import this package Photon_FixTeamsManagerNullReferences.zip

Thanks so much for the reply! I will try this soon and report back.

Vauxvogh commented 4 years ago

hmm no that didn't seem to fix it Suriyun. It might be because of this errors I was getting when just a regular death match ended. These errors below happens after every regular deathmatch, though it doesn't affect deathmatch at all.

https://i.gyazo.com/bf236b6627e28a90a9831450ec1c5002.png

https://i.gyazo.com/6cd9a4d5547bff35375c4352488f093a.png

jonmalave commented 4 years ago

hmm no that didn't seem to fix it Suriyun. It might be because of this errors I was getting when just a regular death match ended. These errors below happens after every regular deathmatch, though it doesn't affect deathmatch at all.

https://i.gyazo.com/bf236b6627e28a90a9831450ec1c5002.png

https://i.gyazo.com/6cd9a4d5547bff35375c4352488f093a.png

Hey @Vauxvogh are you seeing the same problem on your end even after applying the above fix @insthync provided? I haven't had chance to test this yet...

Vauxvogh commented 4 years ago

Hey! Yeah unfortunately even after applying the above fix it didn't work.

insthync commented 4 years ago

As I try, the error occuring when team death match end but it won't affect gameplay, right?

The codes that cause error is Photon's codes, I actually can avoid it and error messages by just add null check at top of ClearTeams function

PhotonTeamsManager.cs

        private void ClearTeams()
        {
            if (playersPerTeam == null)
                return;
            foreach (var key in playersPerTeam.Keys)
            {
                playersPerTeam[key].Clear();
            }
        }
Vauxvogh commented 4 years ago

Hey Suriyun, yes it does affect gameplay for Team Deathmatch. After you play 1 match of Team Death match it doesn't clear the data from that match, so if you go to play another match of Team death match the End game panel will automatically show saying the match is over because a player already won (from the last time you played a team deathmatch)

But regular deathmatch and I.O mode don't seem to be affected nor battle royale. Only team Death match. However those errors I showed above to do appear (after) I play a regular deathmatch or I.O mode. But don't affect those modes, only team deathmatch. :)

insthync commented 4 years ago

Ahhh, I see, I will fix it, I might upload the new package within 3 hrs.

Vauxvogh commented 4 years ago

Ok sounds great Thanks Suriyun! Hey could you check Status Effects that apply damage over time? So if I have a damage entity that applies a status effect and it takes health away from the target over time and they die, it doesn't give me the kill or score, they just die. Was this on purpose or its still supposed to count as a kill right if the status effect kills them?

insthync commented 4 years ago

Okay, I will fix it

Vauxvogh commented 4 years ago

ok thanks man! we appreciate you!

jonmalave commented 4 years ago

@insthync what is the fix for this?

insthync commented 4 years ago

Fix kill count/score not reset when start new game.

jonmalave commented 4 years ago

Fix kill count/score not reset when start new game.

you pushed the fix in the latest release you mean?

insthync commented 4 years ago

Yes, I mean I've pushed it in latest release