[Question]Queued Workbench

[moepi2k]

Hello, i try to modify the Queued Workbench so that the queue list is only for local player instead of global, so it wont block other players to use the workbench.

can u lead me in the right direction to do it? i assume in the CraftingQueueSourceExtensions.cs

i need to modify the

public static bool AppendCraftingQueueItem(this ICraftingQueueSource source, IPlayerCharacterData crafter, uint crafterId, int dataId, int amount, out UITextKeys errorMessage)
{
    errorMessage = UITextKeys.NONE;
    if (!source.CanCraft)
        return false;
    ItemCraftFormula itemCraftFormula;
    if (!GameInstance.ItemCraftFormulas.TryGetValue(dataId, out itemCraftFormula))
        return false;
    if (!itemCraftFormula.ItemCraft.CanCraft(crafter, out errorMessage))
        return false;
    if (source.QueueItems.Count >= source.MaxQueueSize)
        return false;
    source.QueueItems.Add(new CraftingQueueItem()
    {
        crafterId = crafterId,
        dataId = dataId,
        amount = amount,
        craftRemainsDuration = itemCraftFormula.CraftDuration,
    });
    return true;
}

to eg something like this?

public static bool AppendCraftingQueueItem(this ICraftingQueueSource source, IPlayerCharacterData crafter, uint crafterId, int dataId, int amount, out UITextKeys errorMessage)
{
    errorMessage = UITextKeys.NONE;
    if (!source.CanCraft)
        return false;
    ItemCraftFormula itemCraftFormula;
    if (!GameInstance.ItemCraftFormulas.TryGetValue(dataId, out itemCraftFormula))
        return false;
    if (!itemCraftFormula.ItemCraft.CanCraft(crafter, out errorMessage))
        return false;

    // Check if the player already has a queue, if not, create one
    if (!source.PlayerSpecificQueues.ContainsKey(crafterId))
        source.PlayerSpecificQueues[crafterId] = new List<CraftingQueueItem>();

    var playerQueue = source.PlayerSpecificQueues[crafterId];
    if (playerQueue.Count >= source.MaxQueueSize)
        return false;

    playerQueue.Add(new CraftingQueueItem()
    {
        crafterId = crafterId,
        dataId = dataId,
        amount = amount,
        craftRemainsDuration = itemCraftFormula.CraftDuration,
    });
    return true;
}

[LordPhrozen]

That would be fantastic.

[insthync]

Create a new component which implements ICraftingQueueSource and will be attached to player entity, you may look at the PlayerCharacterCraftingComponent as an example, might have to change queueItems by interacting building.

Did you think about the situation when the player stop interacting with building or change interacting building? should the queueItems be reset when the player stop interacting or not, did you think something like that?

[moepi2k]

yes thought about that too. actually the function should be same like it is right now. just that the queue list is not synced via players. because a player always block the workbench. and its bad to place 10 workbench next to each other so player can craft

[insthync]

Did you think about the situation when the player stop interacting with building or change interacting building? should the queueItems be reset when the player stop interacting or not, did you think something like that?

[insthync]

How it should works?

[moepi2k]

yes that what im saying, from the function. queue list is only for owning player. so when player stop interacting or move away, the queue list cancel/reset. same like it is for right now. only diffrence should be that other player can also use the workbench at same time without seeing what other player crafting atm. actually at first i thought it is like this, since alot of players pm me and asked to change this since the workbench is always blocked be queue list of other players.

i not messed with it for now. i just asking where i need to look to change that before starting.

[insthync]

I've added public queue setting to the building entity, turn it off then when crafting it will use player's crafting source for queueing and updating

[moepi2k]

niiiice, thank u very much. i will send u some coffee :)