suriyun-production / mmorpg-kit-docs

This is document for MMORPG KIT project (https://www.assetstore.unity3d.com/#!/content/110188?aid=1100lGeN)
https://suriyun-production.github.io/mmorpg-kit-docs
49 stars 10 forks source link

[Bug]seed of items change #2599

Closed moepi2k closed 2 weeks ago

moepi2k commented 3 weeks ago

when u have an item with random bonus (seed) when u put it in auction house it changes the seed

this is before i put ring into auction house https://gyazo.com/fc320c375cf7319fd6cfe9c0ba7d2e41

this when its in auction house https://gyazo.com/6deb4e0c2bdd926e9c1de85752a380fc

when u cancel the action or someone buy it out and u claim from post it will keep the changed seed which was in the auction house so actually its not just a visual issue

insthync commented 3 weeks ago

Please list when the seed changed

moepi2k commented 3 weeks ago

at the moment when u create the auction. need to check when back from work

insthync commented 2 weeks ago

Really cannot reproduce, when is your last update for those 2 repos?

moepi2k commented 2 weeks ago

For auction house and service. Its latest. Do you have an item with random bonuse and put it in auction house?

insthync commented 2 weeks ago

Yes, why will I test seed changing without items that won't have random bonus?

insthync commented 2 weeks ago

May try check read/write items function here

https://github.com/suriyun-mmorpg/UnityMultiplayerARPG_SharedData/blob/main/Scripts/CharacterData/CharacterDataExtensions.cs

moepi2k commented 2 weeks ago

U tested it with latest kit version?

insthync commented 2 weeks ago

Yes I never test on the old version, why I have to test on the older versions?

moepi2k commented 2 weeks ago

so how should i test on latest when its not released yet. maybe its fixed there somewhere already

insthync commented 2 weeks ago

How should you test? you said issues occurring when create an auction then you have to debug a create auction part, that is it

I told you to check mail items read/write did you do it?

Hint in case you are inability to debug create auction part, check the seed here, and here

moepi2k commented 2 weeks ago

ok then i will setup fresh kit with 189 and new auction and try again. but i cant see any changes in the read write stuff from 188 to 189 so i wondering why you are not able to reproduce it. or if its possible would be nice to send a current version of the core so i can also test with it since u dont know when u gonna release it

insthync commented 2 weeks ago

Try debugging the seed value first.

moepi2k commented 2 weeks ago

ok will do it when at home, thx

moepi2k commented 2 weeks ago

ok debuged it and its even more weird now. when i create the item the seed is -1992666332. after puting in auction house the seed NOT change, even when i put out of mailbox. so seed is always correct. but the bonus attributes of the item changes one time when u put it in the auction house. and only one time. the second time it will be like it was after changed once.

c0e7fd587a306a8a08e1f23b62b7bf05

as u see in video initial bonus attribute is +2 endurance +5 intelligence

after puting to auctionhouse its

+15 dexterity +17 luck

how can this happen o.O

moepi2k commented 2 weeks ago

-> same happen with fresh kit

https://gyazo.com/3121343c917e1e18c8bd8d5c7bcca1c4

moepi2k commented 2 weeks ago

ok found the issue. characteritem -> version. normal its 2. when it write to auction it changes to 0. dont know why but it changes item data

insthync commented 2 weeks ago

So what you have told me that put item in/out to auction can random stats every time is wrong it is actaully can be changed once (by change version to 0), so seed never changed but version will be changed to 0, which lead me unable to reproduce correctly.

insthync commented 2 weeks ago

This is the fix https://github.com/suriyun-mmorpg/UnityMultiplayerARPG_SharedData/commit/a5818963fe47e07b736d6cde4126cf26b0fe06b6