search

surjit / oauth

Automatically exported from code.google.com/p/oauth
0 stars 0 forks source link

php: Replace OAuthRequest::generate_nonce with OAuthDataStore::new_nonce #15

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
OAuthDataStore has lookup_nonce method, but nonce generation is placed in
OAuthRequest::generate_nonce, which doesn't have access to storage. I
think there should be OAuthDataStore::new_nonce() method. I'm submitting 
a preliminary patch for this, however  currently it breaks examples because of 
changed from_consumer_and_token() signature.

Original issue reported on code.google.com by atregoub...@gmail.com on 25 Mar 2008 at 10:06

Attachments:

GoogleCodeExporter commented 9 years ago 
nonce generation is on OAuthRequest because it needs to generate nonces to make
requests, nonce lookup is on the datastore because the datastore is checking 
whether
a nonce being provided has already been provided, hence it has already been 
given a
nonce and does not need to generate one.

Original comment by andyster on 15 Jul 2008 at 10:04