search

surrealdb / surrealdb.go

SurrealDB SDK for Golang
https://surrealdb.com
Apache License 2.0
232 stars 60 forks source link

Feature/handle live query diff #105

Closed Atoo35 closed 9 months ago

Atoo35 commented 10 months ago

@phughk i am pretty sure i have done something horrible in here. guide me please

This PR resolves issue #81

Atoo35 commented 10 months ago

@phughk i have fixed like you suggested. Although not sure why the test is failing here on github, being a developer "it worked just fine on my machine" !!

ilkerkorkut commented 10 months ago

@phughk i have fixed like you suggested. Although not sure why the test is failing here on github, being a developer "it worked just fine on my machine" !!

Most probably it's related with that issue -> https://github.com/surrealdb/surrealdb.go/issues/75

ElecTwix commented 9 months ago

@phughk i have fixed like you suggested. Although not sure why the test is failing here on github, being a developer "it worked just fine on my machine" !!

that issue was fixed with #109 You can continue your work :)

Atoo35 commented 9 months ago

thanks @ElecTwix the work was done already, was just stuck in the test pipeline here. @phughk is this fine to be merged now?

Atoo35 commented 9 months ago

@phughk made the change as requested. Thanks a lot !