search

surrealdb / surrealdb.go

SurrealDB SDK for Golang
https://surrealdb.com
Apache License 2.0
232 stars 60 forks source link

build: Add tests for fetch using passing arguments #115

Closed sbshah97 closed 7 months ago

sbshah97 commented 9 months ago

Added 5 different test cases to test the fetch functionality. The remaining tests need to be changed once the functionality is fixed at the root source

Closes #40

ElecTwix commented 9 months ago

Maybe we can use unmarshalRaw or smartUnmarshal to make it simpler because there is a lot of casting.

sbshah97 commented 9 months ago

Maybe we can use unmarshalRaw or smartUnmarshal to make it simpler because there is a lot of casting.

Yep I was thinking of doing it in the follow up PR once this goes in. Can you help me with how those would be used here?

I am not sure how to use those methods, at the end of the README there were some examples but didn't really help.

phughk commented 9 months ago

We should wait for the unmarshal improvements before merging this. Appreciate the patience and diligence 👍

ElecTwix commented 9 months ago

opened a PR to @sbshah97 's repo https://github.com/sbshah97/surrealdb.go/pull/1 for unmarshal.

sbshah97 commented 7 months ago

@phughk could you review this again?

timpratim commented 7 months ago

Looks good. Thanks @sbshah97 !. Merging it.