Closed ElecTwix closed 2 months ago
TLDR: This pull request aims to address issue #135 without requiring an additional function call.
Hi @ElecTwix , thank you for the PR. Everything looks great. It would be great if we could add a test case for the Send
method in the same PR. Happy to merge the PR then.
It would be great if we could add a test case for the
Send
method in the same PR.
Hi @timpratim added test named connectionBreakAndClose
for test the Send
method to checks it's error return. I would like to add tests directly but it require mocks for gorilla itself for make it simpler I came up with this but in my next PRs, I will address this too.
Thank you @ElecTwix. Appreciate it! Merging the PR.
fix #119 instead of panic it will return error when any send function call when connection lost.