Closed EtienneBruines closed 2 years ago
Would it be preferable to have pre-commit as well?
Personally I'd say yes - but with Go there's (as far as I know) no predefined way of doing so, so I wouldn't really know.
But yes, it makes sense that most things the CI/CD would test (like linting) would be part of the pre-commit.
I believe we can close this issue since we are running golangci-lint on github actions now https://github.com/surrealdb/surrealdb.go/pull/25
Good catch @ffrizzo !
It'd be nice to automate the testing and linting, to make pull requests validated easier.
These things might be nice to include:
go fmt
goimports
go mod tidy
go mod verify
go vet
staticcheck
- see https://staticcheck.io/gosec
- see https://github.com/securego/gosecgo test