surrealdb / surrealdb.go

SurrealDB SDK for Golang
https://surrealdb.com
Apache License 2.0
240 stars 66 forks source link

GitHub actions for linting and testing #23

Closed EtienneBruines closed 2 years ago

EtienneBruines commented 2 years ago

It'd be nice to automate the testing and linting, to make pull requests validated easier.

These things might be nice to include:

tpotjj commented 2 years ago

Would it be preferable to have pre-commit as well?

EtienneBruines commented 2 years ago

Personally I'd say yes - but with Go there's (as far as I know) no predefined way of doing so, so I wouldn't really know.

But yes, it makes sense that most things the CI/CD would test (like linting) would be part of the pre-commit.

ffrizzo commented 2 years ago

I believe we can close this issue since we are running golangci-lint on github actions now https://github.com/surrealdb/surrealdb.go/pull/25

EtienneBruines commented 2 years ago

Good catch @ffrizzo !