search

surrealdb / surrealdb.go

SurrealDB SDK for Golang
https://surrealdb.com
Apache License 2.0
240 stars 66 forks source link

Move websocket to the internal package #26

Closed ffrizzo closed 2 years ago

ffrizzo commented 2 years ago

This is a proposal of moving WebSocket code into the internal folder and, with that, hiding it from the users and only providing a straightforward interface using the DB implementation

⚠️ This PR is based on #25. ⚠️ The relevant commit on this one is https://github.com/surrealdb/surrealdb.go/commit/a49d7bfbbf93498667abf5a70fe1499cd39a519a

tobiemh commented 2 years ago

Hi @ffrizzo I'm not sure if this is relevant since #27 has been merged?

ffrizzo commented 2 years ago

Hi @ffrizzo I'm not sure if this is relevant since #27 has been merged?

Yes. This is not needed anymore.