search

surrealdb / surrealdb.go

SurrealDB SDK for Golang
https://surrealdb.com
Apache License 2.0
231 stars 62 forks source link

Added NewWithOptions func #51

Closed ElecTwix closed 1 year ago

ElecTwix commented 1 year ago

Added NewWithTimeout func for set timeout custom time Update UnmarshalRaw returning just an error.

ElecTwix commented 1 year ago
ElecTwix commented 1 year ago

Leaving a comment in haste because I have an urgent rust thing to get to, but I think overall it's nice to have these changes thank you!

No Problem.

I would certainly prefer converging to the single New interface though. We don't need excessive functions.

I got your point still we need some struct for creating an interface method. Still, I think we don't need more functions or make other ones excessive function. Also maybe I'm wrong I would like to listen to what is your plan about this.

I was also wondering about the visitor pattern used for the options... maybe that could be changed?

I was thinking the user can provide the struct as a parameter then we just set the field with the original.

phughk commented 1 year ago

This is really good work, thank you @ElecTwix ! And thank you as well for reviewing @plally it's mega helpful!