search

surrealdb / surrealdb.go

SurrealDB SDK for Golang
https://surrealdb.com
Apache License 2.0
231 stars 62 forks source link

Logger added. #66

Closed ElecTwix closed 1 year ago

ElecTwix commented 1 year ago

Logger Added. It was on TODO I wanted to complete it.

phughk commented 1 year ago

Can we please use https://github.com/sirupsen/logrus instead? It has levels and already has all the functionality we need. Thanks for adding this though!

ElecTwix commented 1 year ago

Can we please use https://github.com/sirupsen/logrus instead? It has levels and already has all the functionality we need. Thanks for adding this though!

I'm not sure about it, it says "Logrus is in maintenance-mode". If still we want that I will happily implement just wanted to point it out.

phughk commented 1 year ago

I have used it in the past, but actually you are right. We should pick one of

Zerolog seems to be an improvement on zap, and apex seems to be an integration on top of logging libraries. In that case I think we should use zerolog. What do you think?

ElecTwix commented 1 year ago

Zerolog seems to be an improvement on zap, and apex seems to be an integration on top of logging libraries. In that case I think we should use zerolog. What do you think?

Yeah, I agree I added zerolog implementation and some unit tests.