surrealdb / surrealdb.go

SurrealDB SDK for Golang
https://surrealdb.com
Apache License 2.0
231 stars 62 forks source link

Test websocket concurrent #64 #69

Closed ElecTwix closed 1 year ago

ElecTwix commented 1 year ago

Close #64

timpratim commented 1 year ago

Hi @ElecTwix , thank you for your work on this PR. The changes look good! Could you please address the remaining lint issues? Once those are fixed, I'll be able to proceed with merging the PR.

ElecTwix commented 1 year ago

Hi @timpratim when I run golangci-lint it seems fine and when I look into the error it gives error on testify that was almost added 4-5 months ago by @phughk Could you rerun ci-linter for test thanks :)

My output:


❯ golangci-lint run -v
INFO [config_reader] Config search paths: [./ /home/electwix/dev/go/surrealdb.go /home/electwix/dev/go /home/electwix/dev /home/electwix /home /] 
INFO [config_reader] Used config file .golangci.yml 
INFO [lintersdb] Active 31 linters: [bodyclose depguard dogsled dupl errcheck exportloopref funlen gochecknoinits goconst gocritic gocyclo gofmt goimports gomnd goprintffuncname gosec gosimple govet ineffassign lll misspell nakedret noctx nolintlint staticcheck stylecheck typecheck unconvert unparam unused whitespace] 
INFO [loader] Go packages loading at mode 575 (compiled_files|exports_file|name|types_sizes|deps|files|imports) took 72.816479ms 
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 878.124µs 
INFO [linters_context/goanalysis] analyzers took 0s with no stages 
INFO [runner] Issues before processing: 25, after processing: 0 
INFO [runner] Processors filtering stat (out/in): autogenerated_exclude: 25/25, nolint: 0/10, identifier_marker: 25/25, exclude-rules: 10/25, filename_unadjuster: 25/25, skip_files: 25/25, path_prettifier: 25/25, exclude: 25/25, cgo: 25/25, skip_dirs: 25/25 
INFO [runner] processing took 1.734068ms with stages: nolint: 678.215µs, exclude-rules: 521.597µs, identifier_marker: 302.928µs, path_prettifier: 101.389µs, autogenerated_exclude: 75.959µs, skip_dirs: 47.27µs, cgo: 3µs, filename_unadjuster: 1.15µs, max_same_issues: 520ns, source_code: 290ns, fixer: 270ns, exclude: 230ns, skip_files: 200ns, severity-rules: 190ns, uniq_by_line: 180ns, max_from_linter: 160ns, diff: 110ns, path_shortener: 110ns, sort_results: 110ns, max_per_file_from_linter: 100ns, path_prefixer: 90ns 
INFO [runner] linters took 186.443798ms with stages: goanalysis_metalinter: 184.65996ms 
INFO File cache stats: 0 entries of total size 0B 
INFO Memory: 4 samples, avg is 57.4MB, max is 82.9MB 
INFO Execution took 262.828254ms  ```