search

surrealdb / surrealdb.java

SurrealDB SDK for Java
https://surrealdb.com
Apache License 2.0
67 stars 21 forks source link

Jdbc unittest stubs #34

Closed eharrow closed 1 year ago

eharrow commented 1 year ago

This PR retrofits some unit tests to the current code base. In the case of the early cut of the JDBC code it verifies that UOE are thrown which means that these tests will require refactoring once the actual code is implemented.

phughk commented 1 year ago

I am removing the draft tag. I will give it a day or 2 before landing. But the changes included already are good to land.

eharrow commented 1 year ago

Planning to add the same style stub tests for the remaining jdbc classes for the auto generated overrides if you want to hold fire for a few days.

eharrow commented 1 year ago

Yes disabling probably works in this case once the stubs created. Different strokes… .

phughk commented 1 year ago

Already approved, waiting for it to come out of draft before final review and merging. Looks good, thanks!

eharrow commented 1 year ago

Already approved, waiting for it to come out of draft before final review and merging. Looks good, thanks!

Done

phughk commented 1 year ago

Thanks so much for this!!

flipflopsen commented 1 year ago

@phughk Is there already active work on the JDBC Driver implementation? I started to work on this but facing some problems with this, maybe we can work together on this and interchange information? In case I am on the official Surreal Discord to find under the name flipflop, otherwise Discord directly: flipflop#1337.

I would really appreciate a message! :)

Sorry for communication over this PR, but I haven't seen another possible way of communicating haha.

phughk commented 1 year ago

Heya! Thanks so much for that! Sent a friend request and continuing convo on the surrealdb discord java channel :)