search

surrealdb / surrealdb.java

SurrealDB SDK for Java
https://surrealdb.com
Apache License 2.0
67 stars 21 forks source link

#41 - Removing marketing and tags and fixing test #49

Closed thomas-turner closed 1 year ago

thomas-turner commented 1 year ago

Just thought I'd give an issue a go as I find the project interesting, hopefully that's ok. Think I've done this right? Spotless runs just fine.

thomas-turner commented 1 year ago

Great changes thank you! Some formatting stuff but I am hoping these are enforced by checkstyle. Merging 🎉

@phughk Yeah hopefully, I did run spotlessJavaApply so should be however the stylesheet recommends 😃

eharrow commented 1 year ago

Hi all

@thomas-turner the integration test suite fails in testSignUp(). Please rerun and check.


2023-06-15 15:00:01.481  INFO [Test worker    ] 🐳 [surrealdb/surrealdb:latest]          : Container surrealdb/surrealdb:latest started in PT0.268348S
2023-06-15 15:00:01.526 ERROR [ctReadThread-28] c.s.c.SurrealWebSocketConnection         : Received RPC error: id=1 code=-32000 message=There was a problem with authentication
2023-06-15 14:55:17.721 ERROR [ctReadThread-62] c.s.c.SurrealWebSocketConnection         : Received RPC error: id=1 code=-32000 message=There was a problem with authentication
com.surrealdb.connection.exception.SurrealAuthenticationException
    at app//com.surrealdb.connection.ErrorToExceptionMapper.map(ErrorToExceptionMapper.java:22)
    at app//com.surrealdb.connection.SurrealWebSocketConnection.onMessage(SurrealWebSocketConnection.java:148)
    at app//org.java_websocket.client.WebSocketClient.onWebsocketMessage(WebSocketClient.java:636)
    at app//org.java_websocket.drafts.Draft_6455.processFrameText(Draft_6455.java:986)
    at app//org.java_websocket.drafts.Draft_6455.processFrame(Draft_6455.java:910)
    at app//org.java_websocket.WebSocketImpl.decodeFrames(WebSocketImpl.java:401)
    at app//org.java_websocket.WebSocketImpl.decode(WebSocketImpl.java:233)
    at app//org.java_websocket.client.WebSocketClient.run(WebSocketClient.java:516)
    at java.base@17.0.7/java.lang.Thread.run(Thread.java:833)
thomas-turner commented 1 year ago

Hi all

@thomas-turner the integration test suite fails in testSignUp(). Please rerun and check.


2023-06-15 15:00:01.481  INFO [Test worker    ] 🐳 [surrealdb/surrealdb:latest]          : Container surrealdb/surrealdb:latest started in PT0.268348S
2023-06-15 15:00:01.526 ERROR [ctReadThread-28] c.s.c.SurrealWebSocketConnection         : Received RPC error: id=1 code=-32000 message=There was a problem with authentication
2023-06-15 14:55:17.721 ERROR [ctReadThread-62] c.s.c.SurrealWebSocketConnection         : Received RPC error: id=1 code=-32000 message=There was a problem with authentication
com.surrealdb.connection.exception.SurrealAuthenticationException
  at app//com.surrealdb.connection.ErrorToExceptionMapper.map(ErrorToExceptionMapper.java:22)
  at app//com.surrealdb.connection.SurrealWebSocketConnection.onMessage(SurrealWebSocketConnection.java:148)
  at app//org.java_websocket.client.WebSocketClient.onWebsocketMessage(WebSocketClient.java:636)
  at app//org.java_websocket.drafts.Draft_6455.processFrameText(Draft_6455.java:986)
  at app//org.java_websocket.drafts.Draft_6455.processFrame(Draft_6455.java:910)
  at app//org.java_websocket.WebSocketImpl.decodeFrames(WebSocketImpl.java:401)
  at app//org.java_websocket.WebSocketImpl.decode(WebSocketImpl.java:233)
  at app//org.java_websocket.client.WebSocketClient.run(WebSocketClient.java:516)
  at java.base@17.0.7/java.lang.Thread.run(Thread.java:833)

@eharrow That failed in main prior to my changes for me, assumed it was an M1 issue or something since the repo checks passed.

eharrow commented 1 year ago

I have opened https://github.com/surrealdb/surrealdb.java/issues/50 to at least change the build so it fails and that way the failing test might be addressed.

On Thursday, Jun 15, 2023 at 3:05 pm, Tom Turner @. @.)> wrote:

Hi all

@thomas-turner (https://github.com/thomas-turner) the integration test suite fails in testSignUp(). Please rerun and check.

2023-06-15 15:00:01.481 INFO [Test worker ] 🐳 [surrealdb/surrealdb:latest] : Container surrealdb/surrealdb:latest started in PT0.268348S 2023-06-15 15:00:01.526 ERROR [ctReadThread-28] c.s.c.SurrealWebSocketConnection : Received RPC error: id=1 code=-32000 message=There was a problem with authentication 2023-06-15 14:55:17.721 ERROR [ctReadThread-62] c.s.c.SurrealWebSocketConnection : Received RPC error: id=1 code=-32000 message=There was a problem with authentication com.surrealdb.connection.exception.SurrealAuthenticationException at app//com.surrealdb.connection.ErrorToExceptionMapper.map(ErrorToExceptionMapper.java:22) at app//com.surrealdb.connection.SurrealWebSocketConnection.onMessage(SurrealWebSocketConnection.java:148) at app//org.java_websocket.client.WebSocketClient.onWebsocketMessage(WebSocketClient.java:636) at app//org.java_websocket.drafts.Draft_6455.processFrameText(Draft_6455.java:986) at app//org.java_websocket.drafts.Draft_6455.processFrame(Draft_6455.java:910) at app//org.java_websocket.WebSocketImpl.decodeFrames(WebSocketImpl.java:401) at app//org.java_websocket.WebSocketImpl.decode(WebSocketImpl.java:233) at app//org.java_websocket.client.WebSocketClient.run(WebSocketClient.java:516) at @.***/java.lang.Thread.run(Thread.java:833)

@eharrow (https://github.com/eharrow) That failed in main prior to my changes for me, assumed it was an M1 issue or something since the repo checks passed.

— Reply to this email directly, view it on GitHub (https://github.com/surrealdb/surrealdb.java/pull/49#issuecomment-1593136445), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AABAYFXX3QLRDMYHO7WQXALXLMJBBANCNFSM6AAAAAAZEZV6CI). You are receiving this because you were mentioned.Message ID: @.***>

phughk commented 1 year ago

Hey @eharrow , this is all good but thanks for highlighting. We knew the risks of landing and enabling ITs. In surrealdb/surrealdb we would have reverted because it is extremely important to keep nightly alive. For drivers, we can work things out as they are more tied to releases.

We won't revert this change, even if it breaks things (may change my mind if I'm wrong). The perfect situation would have been to fix tests before enabling testing in cicd. We aren't doing that. So we need to fix the tests now that they are failing.

Thanks all for helping make this - it is hard work, and we appreciate the care you are putting into making it work ❤️

eharrow commented 1 year ago

Ok so the underlying issue is tracked in https://github.com/surrealdb/surrealdb.java/issues/35