search

surrealdb / surrealdb.java

SurrealDB SDK for Java
https://surrealdb.com
Apache License 2.0
67 stars 21 forks source link

Fix SLF4J #5

Closed coder966 closed 1 year ago

coder966 commented 1 year ago

downgrade SLF4J to v1 because v2 is too new it is not yet supported by most frameworks. Currently with v2 (release Aug 2022), this driver won't work on Spring framework.

phughk commented 1 year ago

Hey @coder966 ! Thanks for opening the PR and explaining the problem. I don't think we should be downgrading libraries. It may be the issue that this isn't actually SLF4J being on 2, but logback actually. Intersting that the logback downgrade works - have you tried upgrading logback in your Spring project? It is declared as test implementation here so should not have an effect on dependencies

coder966 commented 1 year ago

@phughk The problem was a conflict of versions of slf4j, since Spring brings slf4j v1 to the runtime classpath, and this library brings slf4j v2 to the runtime (and compile time) classpath. The fix is to use compileOnly depdendecy scope. Now the version is kept at v2.