search

surrealdb / surrealdb.java

SurrealDB SDK for Java
https://surrealdb.com
Apache License 2.0
67 stars 21 forks source link

Add namespace and database sign in #7

Closed CheeseTastisch closed 1 year ago

CheeseTastisch commented 1 year ago

Add methods to signin with a namespace or database account

CheeseTastisch commented 1 year ago

I think it would be better to focus on pull request #6. As the changes in #6 seem like better improvements to me and if #6 ​​is merged this pull request will be deprecated anyway.

phughk commented 1 year ago

It might be better, but it has so many issues due to it's size. We cannot merge it as-is even if all the issues are addressed. We need separate changes per modification. This helps track changes across versions, identify relevant changes, revert if necessary, cherry pick across versions... That PR is too big. But I agree it has a lot of merit. I will leave this up to you - if you would like to improve this solution, then it will be much faster as that other change really needs to be split properly.