Use modern Java and cleanups

[JFortun]

This PR is a refactor of the project to:

• Fix some common issues
• Remove unused imports
• Use immutable records instead of classes when possible and avoid lombok to make code more readable and shorter
• Added a ton of missing final keywords when possible
• Run gradle :spotlessApply to correct formatting
• Use lambdas in a lot of places when possible to reduce the complexity of the code

[phughk]

Hey thanks! Will merge this once conflicts are resolved! 🎉

[JFortun]

Hey thanks! Will merge this once conflicts are resolved! 🎉

Hello @phughk, conflicts resolved.

[JFortun]

@phughk Can you assign this PR to me? I don't have access.

[phughk]

Actually just gave it a proper read (yesterday was at the hacktoberfest event so split attention). I thought this was just spotless apply - not sure why variables inside blocks are being made final? They are "final" in a way, but constantly writing final is terse and we don't need the keyword because it isn't exposed beyond the function. So it is unnecessary and having final made explicit may give the wrong impression that its deliberate (when I believe what you mean is that it isn't modified i.e. implicit). Could you revert the final keywords please? RE assigning - assigning is for who owns the review. Will assign to me.

[JFortun]

Actually just gave it a proper read (yesterday was at the hacktoberfest event so split attention). I thought this was just spotless apply - not sure why variables inside blocks are being made final? They are "final" in a way, but constantly writing final is terse and we don't need the keyword because it isn't exposed beyond the function. So it is unnecessary and having final made explicit may give the wrong impression that its deliberate (when I believe what you mean is that it isn't modified i.e. implicit).

Could you revert the final keywords please?

RE assigning - assigning is for who owns the review. Will assign to me.

Thanks for the review @phughk.

The final keywords serve a purpose, even if the variable is not exposed beyond the function, the JVM is able to do some optimizations when we set a varible as final. Here you have some benchmarks and info about the advantages

About assigning, that's not for the one that does the review. Who owns the review goes in the "reviewers" field just above. The PRs are assigned to the ones working on them. Each field has their purpose.

[phughk]

Based on the 2 answers in SO (not docs), people say that assignees are the "stewards" or go to owners of the PR lifecycle (rejected, timely reviews, merging etc). https://stackoverflow.com/questions/41087206/on-github-whats-the-difference-between-reviewer-and-assignee That's how I've been using it so far. The reviewers are just a flexible list of people who need to or have reviewed.

Thanks for sharing about the final stuff I had no idea. Makes a lot of sense :) Re-reviewing now