surrealdb / surrealdb.js

SurrealDB SDK for JavaScript
https://surrealdb.com
Apache License 2.0
294 stars 48 forks source link

select.ts limit,start fix #212

Closed jabis closed 8 months ago

jabis commented 8 months ago

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What is the motivation?

Obvious possibility of having the query fail

What does this change do?

Fixes the limit parameter check that erroneously looks at start

What is your testing strategy?

obviously passing start parameter will also trigger limit which can be undefined

Is this related to any issues?

not seen

Have you read the Contributing Guidelines?

kearfy commented 8 months ago

Ha! Thanks 😄

I had it done locally but was working on some other changes before pushing again

jabis commented 8 months ago

Couldn't resist the edit in place option, as I noticed it wasn't yet forked in my github 🤣