Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
What is the motivation?
We were sending too many fields on auth vars, causing signin to silently fail. Additionally, we were checking for a detail field for errors, while it was simply result
What does this change do?
Fixes above
What is your testing strategy?
Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.
Is this related to any issues?
If this pull request is related to any other pull request or issue, or resolves any issues - then link all related pull requests and issues here.
Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
What is the motivation?
We were sending too many fields on auth vars, causing signin to silently fail. Additionally, we were checking for a
detail
field for errors, while it was simplyresult
What does this change do?
Fixes above
What is your testing strategy?
Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.
Is this related to any issues?
If this pull request is related to any other pull request or issue, or resolves any issues - then link all related pull requests and issues here.
Have you read the Contributing Guidelines?