Closed kearfy closed 6 days ago
Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
In an oversight, PreparedQuery used just a bare minimal CBOR encoder, leaving custom tags such as record ids not properly encoded.
PreparedQuery
Alters the partiallyEncodeObject method to accept all encode options, allowing the PreparedQuery class to pass a replacer to the CBOR encode method.
partiallyEncodeObject
Added a test to ensure that prepared queries have replacer context.
No
Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
What is the motivation?
In an oversight,
PreparedQueryused just a bare minimal CBOR encoder, leaving custom tags such as record ids not properly encoded.What does this change do?
Alters the
partiallyEncodeObjectmethod to accept all encode options, allowing thePreparedQueryclass to pass a replacer to the CBOR encode method.What is your testing strategy?
Added a test to ensure that prepared queries have replacer context.
Is this related to any issues?
No
Have you read the Contributing Guidelines?