Closed kearfy closed 1 month ago
Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
As reported in Discord, our custom CBOR implementation had some serious performance implications
Made some improvements to the encoder, decoder, writer and reader, making the CBOR implementation even faster than the original library that we used.
GitHub CI. Benchmark tests to be added soon to prevent this sort of performance decline from happening in the future.
No
Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
What is the motivation?
As reported in Discord, our custom CBOR implementation had some serious performance implications
What does this change do?
Made some improvements to the encoder, decoder, writer and reader, making the CBOR implementation even faster than the original library that we used.
What is your testing strategy?
GitHub CI. Benchmark tests to be added soon to prevent this sort of performance decline from happening in the future.
Is this related to any issues?
No
Have you read the Contributing Guidelines?