Open ViniciusLucchesi opened 10 months ago
Hi,
I noticed that the latest commit appears to be unrelated to the feedback I provided in my previous review. Please let me know if you have any questions about the feedback I provided or if you'd like any clarification on specific points.
I want to clarify that I don't have merge access and my initial review was offered from a personal standpoint to provide insights and suggestions.
What is the motivation?
WebSocket only handles 1MB of data and I'm getting this error message
sent 1009 (message too large); no closed frames received
when I try to do aSELECT * FROM my_table
whenmy_table
had more than 1 MB of data.Type of Change
What does this change do?
These changes allow the user to specify what is the max size of the data that the WebSocket connection to the SurrealDB will be capable to handle.
What is your testing strategy?
This script will print on the terminal all data from your table, but if you remove the
max_size
parameter fromconnect
method the max size handle will be only 1 MB as default.Is this related to any issues?
No
Have you read the Contributing Guidelines?